MNT: Use BitsAndBytesConfig as load_in_* is deprecated #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't pass load_in_4bit or load_in_8bit to AutoModel*.from_pretrained, as it is deprecated. Instead, pass the appropriate BitsAndBytesConfig to the quantization_config argument of from_pretrained.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
added a commit
to BenjaminBossan/peft
that referenced
this pull request
Mar 28, 2024
These were caused by an incorrect search and replace operation in huggingface#1552.
BenjaminBossan
added a commit
that referenced
this pull request
Apr 5, 2024
Several tests were using bnb_4bit_compute_type but the argument should be called bnb_4bit_compute_dtype. Now the correct name is used. This change should not affect the tests, because they were passing the default value anyway. Therefore, the fact that this argument was passed incorrectly (and thus, presumably, ignored) should not affect the results. Also, fix another incorrect argument to bnb config. These were caused by an incorrect search and replace operation in #1552.
BenjaminBossan
added a commit
to BenjaminBossan/peft
that referenced
this pull request
May 30, 2024
Don't pass load_in_8bit to AutoModel.from_pretrained, instead use BitsAndBytesConfig. There was already a PR to clean this up (huggingface#1552) but a slightly later PR (huggingface#1518) re-added this usage.
BenjaminBossan
added a commit
that referenced
this pull request
May 30, 2024
Don't pass load_in_8bit to AutoModel.from_pretrained, instead use BitsAndBytesConfig. There was already a PR to clean this up (#1552) but a slightly later PR (#1518) re-added this usage. --------- Co-authored-by: Younes Belkada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't pass
load_in_4bitorload_in_8bittoAutoModel*.from_pretrained, as it is deprecated. Instead, pass the appropriateBitsAndBytesConfigto thequantization_configargument offrom_pretrained.